Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Fix history_sidebar_forget_site_verify_if_remembered test case #3690

Merged
merged 4 commits into from
Aug 21, 2019

Conversation

spronoza
Copy link
Contributor

Fix history_sidebar_delete_site_verify_if_remembered test case #3294

@spronoza spronoza self-assigned this Aug 20, 2019
@spronoza spronoza changed the title Fix history_sidebar_delete_site_verify_if_remembered test case Fix history_sidebar_forget_site_verify_if_remembered test case Aug 21, 2019
@pavelciapa pavelciapa self-requested a review August 21, 2019 15:27
Copy link
Contributor

@pavelciapa pavelciapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on osx

        expected_4 = exists(history_today_sidebar_pattern, 10)
>       assert expected_4 is True, 'Expand history button displayed properly.'
E       AssertionError: Expand history button displayed properly.
E       assert False is True

tests/firefox/history/history_sidebar_forget_site_verify_if_remembered.py:53: AssertionError

  • изображение
  • изображение

@pavelciapa pavelciapa self-requested a review August 21, 2019 16:13
Copy link
Contributor

@pavelciapa pavelciapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@paulprokhorovmoz paulprokhorovmoz merged commit 14d712a into dev Aug 21, 2019
@tracywalker
Copy link
Collaborator

The try/except block at lines 69-73 is not necessary around an exists statement. However, Why was the wait_vanish() (which does require being wrapped in a try/except block) removed?

Also, I just filed issue #3723 on reviewing tests using asserting is not True for exists(pattern).

@spronoza
Copy link
Contributor Author

The try/except block at lines 69-73 is not necessary around an exists statement. However, Why was the wait_vanish() (which does require being wrapped in a try/except block) removed?

Also, I just filed issue #3723 on reviewing tests using asserting is not True for exists(pattern).

The wait_vanish is wasn't able to work with string. The "try/except" is just have been forgotten to be removed after replacing it on "exists". My fault

tracywalker pushed a commit that referenced this pull request Aug 26, 2019
* Pattern replaced to string in expected_5

* Region was added to click

* Timeouts changed
@tracywalker tracywalker deleted the issue_3294 branch August 26, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants