You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
When one creates a Pattern via its constructor, we immediately look for the image in a number of reserved locations to establish the correct file path. This is good for enforcing error-checking in code, but has the side effect of a large startup time when you have lots of code that creates new Patterns, e.g. the Firefox target.
I'd like to explore a different approach where we don't do the image lookup until a find-related method has been called. The advantage is that we spread the wait time over the entire run and have an instant startup. One disadvantage might be that any attempts to query a Pattern's properties before this find call would result in some type of error. That might not be an issue, but we can find out by trying.
The text was updated successfully, but these errors were encountered:
@tracywalker That is a consideration. I guess the first thing to do is see if it's even practical. Not sure if it's something localized - and easy to put behind a flag - or something that will require deeper code changes that would result in an all-or-nothing solution.
When one creates a
Pattern
via its constructor, we immediately look for the image in a number of reserved locations to establish the correct file path. This is good for enforcing error-checking in code, but has the side effect of a large startup time when you have lots of code that creates newPatterns
, e.g. the Firefox target.I'd like to explore a different approach where we don't do the image lookup until a
find
-related method has been called. The advantage is that we spread the wait time over the entire run and have an instant startup. One disadvantage might be that any attempts to query aPattern
's properties before thisfind
call would result in some type of error. That might not be an issue, but we can find out by trying.The text was updated successfully, but these errors were encountered: