Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

style(font family): add times instead of fira #7083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreya99oak
Copy link
Contributor

fixes #5742
This fixes a part of #5742 which is adding Times as the font family for IOS users.
@shane-tomlinson @lmorchard Pls. review.

@shreya99oak
Copy link
Contributor Author

Is there any particular reason to use times instead of fira? Cause fira was asked to be created by Mozilla

Copy link

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shreya99oak, the problem that @ryanfeeley wants fixed is that Time is unexpectedly used on iOS instead of Fira. We'd expect Fira to be used instead of times.

@shreya99oak
Copy link
Contributor Author

Thanks @shreya99oak, the problem that @ryanfeeley wants fixed is that Time is unexpectedly used on iOS instead of Fira. We'd expect Fira to be used instead of times.
Oh okay sorry I misinterpreted it

@shane-tomlinson
Copy link

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants