MPP-1810: Update to dockerflow 2024.1.0, remove unused views #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [dockerflow](https://github.com/mozilla-services/python-dockerflow) from 2022.8.0 to 2024.1.0. - [Release notes](https://github.com/mozilla-services/python-dockerflow/releases) - [Changelog](https://github.com/mozilla-services/python-dockerflow/blob/main/docs/changelog.rst) - [Commits](mozilla-services/python-dockerflow@2022.8.0...2024.1.0) --- updated-dependencies: - dependency-name: dockerflow dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
These paths are handled in DockerflowMiddleware, so the ones in our code are unused.
groovecoder
approved these changes
Jan 24, 2024
privaterelay/tests/views_tests.py
Outdated
| @pytest.mark.django_db | ||
| def test_heartbeat_view(client) -> None: | ||
| response = client.get("/__heartbeat__") | ||
| assert response.status_code in (200, 500) |
There was a problem hiding this comment.
question (non-blocking): why is status_code=500 okay here?
There was a problem hiding this comment.
It's one of the two possible responses... Let's be bold and say it is 200 and see where it fails.
Comment on lines
-53
to
-54
| import silk | ||
|
|
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on PR #4309 to use dockerflow 2024.1.0
privaterelay.utils.get_version_info, which provides caching and a default response whenversion.jsonis not present.REDIS_URLis set/__version__,/__heartbeat, and/__lbheartbeat__views, since DockerflowMiddleware handles these before we see them.How to test:
Load in local development, and try:
[ ] l10n changes have been submitted to the l10n repository, if any.[ ] I've added or updated relevant docs in the docs/ directory.[ ] All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss).