Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nimbus): change pop sizing task to crontab scheduling #11852

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore(nimbus): change pop sizing task to crontab scheduling #11852

merged 1 commit into from
Nov 26, 2024

Conversation

mikewilli
Copy link
Contributor

Because

  • Tasks with integer-based scheduling first fire seconds after the latest deploy
  • Pop sizing fetch task is scheduled for 24 hours
  • We often have multiple deployments per day, so 24 hours after the latest deploy will usually not occur until the weekend

This commit

  • changes the scheduling to use crontab so that the task will fire at 06:00 UTC every day regardless of deployments

Fixes #11851

jaredlockhart
jaredlockhart reviewed Nov 26, 2024
View reviewed changes
experimenter/experimenter/settings.py Outdated
@@ -395,7 +395,7 @@
},
"fetch_population_sizing_data": {
"task": "experimenter.jetstream.tasks.fetch_population_sizing_data",
"schedule": 86400,
"schedule": crontab(minute=0, hour=6),
Copy link
Collaborator

@jaredlockhart jaredlockhart Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we wanted this to be weekly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine too, I was debating. I'll update to weekly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done. I changed to only execute on Mondays now (the job runs Sunday).

jaredlockhart
jaredlockhart approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ty 🙏

@mikewilli mikewilli added this pull request to the merge queue Nov 26, 2024
Merged via the queue into mozilla:main with commit 1423172 Nov 26, 2024
16 checks passed
@mikewilli mikewilli deleted the 11851-popsizing-schedule branch November 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@brennie brennie Awaiting requested review from brennie brennie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch popsizing celery fetch task to cron scheduling
2 participants
@mikewilli @jaredlockhart