Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(nimbus): Fix for macos integration-tests #10549

Closed
wants to merge 4 commits into from
Closed

bug(nimbus): Fix for macos integration-tests #10549

wants to merge 4 commits into from

Conversation

b4handjr
Copy link
Contributor

@b4handjr b4handjr commented Apr 10, 2024

Because

  • MacOS seemed to have some issues with running the integration tests

This commit

  • Adds some changes to the makefile commands and updates the readme. The real fix was done upstream

Fixes #10548

@yashikakhurana
Copy link
Contributor

let me test this locally 💪

@yashikakhurana
Copy link
Contributor

tried locally, it is still crashing on local, we are investigating more on this

@brennie brennie changed the title chore(nimbus): Fix for macos integration-tests. bug(nimbus): Fix for macos integration-tests Apr 18, 2024
@yashikakhurana
Copy link
Contributor

Okay I will pull the branch again today and will test all the commands

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing it this way, can we try reverting the base image hash back to the last working one?

This PR still doesn't seem to let me run the tests in a VNC container, which is (at least for me) the important local flow for the integration tests.

@b4handjr
Copy link
Contributor Author

b4handjr commented May 6, 2024

Instead of doing it this way, can we try reverting the base image hash back to the last working one?

This PR still doesn't seem to let me run the tests in a VNC container, which is (at least for me) the important local flow for the integration tests.

Sure, I just dont have much time to mess with it so I can't give an ETA

@b4handjr
Copy link
Contributor Author

b4handjr commented May 7, 2024

Going to close this for now.

@b4handjr b4handjr closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration tests runs for macos
3 participants