Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute bucket size at launch time #3014

Closed
jaredlockhart opened this issue Jul 9, 2020 · 7 comments
Closed

Compute bucket size at launch time #3014

jaredlockhart opened this issue Jul 9, 2020 · 7 comments
Assignees
Labels
API Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html P1 - High Priority Should be prioritized into current batch of work. Workers

Comments

@jaredlockhart
Copy link
Collaborator

When we have real data for audience and features we'll be able to compute the number of buckets an experiment needs. Awaiting details from @tdsmith .

@jaredlockhart jaredlockhart added API Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html Workers labels Jul 9, 2020
@jaredlockhart
Copy link
Collaborator Author

Blocked on data and feedback and design from @tdsmith

@jaredlockhart jaredlockhart added P1 - High Priority Should be prioritized into current batch of work. and removed P1 - High Priority Should be prioritized into current batch of work. labels Jul 13, 2020
@tdsmith
Copy link
Contributor

tdsmith commented Jul 13, 2020

We can afford not to block on this for the A/A MVP; hard-coding 1% will give us the populations we need for that. This'll be more important when we gear up to run real experiments.

I think hashing out a spec for this in the MVP timeframe is reasonable, and I'll work on breaking this down, but the implementation can come later.

@jaredlockhart jaredlockhart changed the title Compute bucket size from audience and features Compute bucket size at launch time Jul 13, 2020
@jaredlockhart
Copy link
Collaborator Author

Blocked on mozilla/nimbus-shared#69

@jaredlockhart
Copy link
Collaborator Author

@jaredlockhart
Copy link
Collaborator Author

@jaredlockhart jaredlockhart added P1 - High Priority Should be prioritized into current batch of work. and removed Blocked labels Jul 20, 2020
tiftran added a commit to tiftran/experimenter that referenced this issue Jul 22, 2020
tiftran added a commit to tiftran/experimenter that referenced this issue Jul 22, 2020
@jaredlockhart
Copy link
Collaborator Author

What we need to do is create the actual bucket range object in the task here:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/kinto/tasks.py#L23-L25

by calling this method:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/experiments/models.py#L1330

and then updating the serializer to actually serialize the bucketrange object instead of returning a hard coded dict

and then THAT has to use the number of buckets from teh design template

@jaredlockhart
Copy link
Collaborator Author

Oh and the namespace is the normandy slug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html P1 - High Priority Should be prioritized into current batch of work. Workers
Projects
None yet
Development

No branches or pull requests

3 participants