Convert FalseLazyObject
to CheckableLazyObject
, use to wrap nonce
#270
+143
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further fix #269, add and test a class
CheckableLazyObject
, which testsTrue
if the object has been accessed and the value generated, andFalse
if it is still "lazy".Use this as the wrapper for
request.csp_nonce
, so that code can test if the nonce is activated before using it:This required a change to the template helpers, to ensure the nonce was read with
str(request.csp_nonce)
. Otherwise, they are treated as falsey.