Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Fix typo for filter object validation message #1123

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix typo for filter object validation message #1123

merged 1 commit into from
Dec 12, 2019

Conversation

uhlissuh
Copy link
Contributor

I was looking at Delivery Console today for something and noticed this typo... figured I'd fix it for fun to open my first pull request on another project in our team stack. If this is indeed a typo...

@uhlissuh
Copy link
Contributor Author

@rehandalal I can't tell if this linting error is related to my tiny lil' change...?

@rehandalal
Copy link
Contributor

@rehandalal I can't tell if this linting error is related to my tiny lil' change...?

It is unrelated and fixed in #1124

Copy link
Contributor

@rehandalal rehandalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d=@uhlissuh

@bors
Copy link
Contributor

bors bot commented Dec 12, 2019

✌️ uhlissuh can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@rehandalal
Copy link
Contributor

rehandalal commented Dec 12, 2019

once the other PR merges you should be able to do a "bors r+" here and it will merge this one

no rebase or merging in master necessary

@uhlissuh uhlissuh merged commit 58be585 into master Dec 12, 2019
@bors bors bot deleted the fix-typo branch December 12, 2019 18:00
@rehandalal
Copy link
Contributor

@uhlissuh for future reference PRs should be merged on this project using "bors r+" not the merge button (i've added protections on master so this will not be possible any longer) and you don't need to do a rebase or merge in master unless there are merge conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants