Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Test warnings #89

Closed
andymikulski opened this issue Apr 5, 2018 · 5 comments · Fixed by #280
Closed

Test warnings #89

andymikulski opened this issue Apr 5, 2018 · 5 comments · Fixed by #280
Assignees
@rehandalal
Labels
improvement P3

Comments

@andymikulski
Copy link
Contributor

In #86 , Normandy tests were converted from Karma/Jasmine to Jest/Enzyme. This in itself is fine, however the tests now spam console warnings while running:

These almost entirely stem from mismatched propTypes, but @magopian made a good point regarding the fact we may uncover bugs by fixing these warnings.
@andymikulski andymikulski mentioned this issue Apr 5, 2018
Merged
@andymikulski andymikulski added the P3 label Apr 5, 2018
@andymikulski andymikulski mentioned this issue Apr 24, 2018
Closed
@peterbe
Copy link
Contributor

peterbe commented Jun 27, 2018

I don't see these warnings any more when I run yarn run test:jest. Is there a thing to enable warnings that I'm missing out on? @rehandalal @magopian

Or, is this a thing of the past?

@rehandalal
Copy link
Contributor

I still see them running: yarn run test

@magopian
Copy link
Contributor

It's weird, I don't see them either...

@magopian
Copy link
Contributor

oh, sorry, I closed, but if @rehandalal can still see them... it would make sense to investigate why he sees them and not us... and then maybe fix those warnings ;)

@magopian magopian reopened this Jun 28, 2018
@peterbe
Copy link
Contributor

peterbe commented Jun 28, 2018

I still see them running: yarn run test

How do you do that?

@rehandalal rehandalal mentioned this issue Jul 5, 2018
Merged
@rehandalal rehandalal self-assigned this Jul 5, 2018
bors bot added a commit that referenced this issue Jul 9, 2018
@bors @rehandalal
Merge #279 #280
bfcb319 
279: Fix URL for new extension button r=magopian a=rehandalal

r?

280: Improve IdenticonField and fix warnings r=magopian a=rehandalal

Sorry @magopian... After reviewing your PR I realized that `IdenticonField` needed a bit of a refactor and ended up fixing all the things.

Fixes #89.
Fixes #202.

r?

Co-authored-by: Rehan Dalal <[email protected]>
@bors bors bot closed this as completed in #280 Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rehandalal rehandalal

Labels
improvement P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve IdenticonField and fix warnings
4 participants
@peterbe @magopian @rehandalal @andymikulski