Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When playing stereo, address the channels by name rather than using 0 and 1 #222

Merged
merged 3 commits into from
May 28, 2024
Merged

When playing stereo, address the channels by name rather than using 0 and 1 #222

merged 3 commits into from
May 28, 2024

Conversation

padenot
Copy link
Collaborator

@padenot padenot commented May 27, 2024

@padenot padenot requested a review from Pehrsons May 27, 2024 14:19
@padenot padenot changed the title When playing mono or stereo, address the channels by name rather than using 0 and 1 When playing stereo, address the channels by name rather than using 0 and 1 May 27, 2024
Pehrsons
Pehrsons requested changes May 27, 2024
View reviewed changes
src/backend/mod.rs Show resolved Hide resolved
Pehrsons
Pehrsons approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Pehrsons Pehrsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of thing seems very likely to go undetected if regressed. I'd love to have a test case, see an idea inline.
I'll leave it to your own discretion, r+.

src/backend/mod.rs Outdated Show resolved Hide resolved
src/backend/tests/manual.rs Show resolved Hide resolved
@padenot padenot merged commit 4cc24c7 into trailblazer May 28, 2024
8 checks passed
@padenot padenot deleted the mono-or-stereo branch May 28, 2024 15:27
@uberjay
Copy link

uberjay commented May 28, 2024

For someone totally unfamiliar with the Firefox release process -- when might this fix make its way into something I can try?

@Pehrsons
Copy link
Contributor

It will be in Nightly soon. Follow along in https://bugzilla.mozilla.org/show_bug.cgi?id=1474175.

@padenot
Copy link
Collaborator Author

padenot commented May 29, 2024

@uberjay this should be available tomorrow in Nightly. This installs alongside a regular Firefox fine without touching your main profile if it's just for testing (not sure how familiar you are with nightly).

General availability in Firefox release is going to be in Firefox 128, July 8th this year.

@uberjay
Copy link

uberjay commented May 31, 2024

Fantastic, the nighty build I just tried plays using the correct channels!!! Thank you all so much, it's greatly appreciated! ❤️

@ChunMinChang ChunMinChang mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pehrsons Pehrsons Pehrsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padenot @uberjay @Pehrsons