Skip to content
This repository has been archived by the owner on Apr 1, 2021. It is now read-only.

React component integration #108

Merged
merged 1 commit into from
Apr 14, 2017
Merged

React component integration #108

merged 1 commit into from
Apr 14, 2017

Conversation

alanmoo
Copy link

@alanmoo alanmoo commented Apr 4, 2017

I copied the compiled CSS and JS files from the network project into the static dir of this project, including them in the pagewithcallout.html template.

The mezzanine template generates a div with data attributes that the react component is already looking for.

Beyond that, we need to figure out how to copy these files from the network site automatically.

@alanmoo alanmoo requested a review from Pomax April 4, 2017 21:05
@alanmoo alanmoo changed the title WIP React component integration React component integration Apr 5, 2017
@Pomax
Copy link

Pomax commented Apr 10, 2017

I don't see any true errors other than a failed image resource (_images/burst1.svg) which is not technically related to this PR but comes from the network side of things.

@alanmoo is there additional testing beyond "I don't see errors and the page hooks into a basket object correctly"? Is there an integration test that needs to be done, too?

@alanmoo
Copy link
Author

alanmoo commented Apr 10, 2017

I'm not sure what you mean by "integration test" in this context, can you clarify?

(Also I added those images but didn't change the source to point at them. Not quite sure what the end goal of this actually is beyond proof-of-concept, which is clearly successful)

@alanmoo alanmoo merged commit 9e9b56e into mozilla:mezzanine Apr 14, 2017
@alanmoo alanmoo deleted the mezzanine branch April 14, 2017 16:19
@alanmoo alanmoo mentioned this pull request Apr 14, 2017
@a-kilroy
Copy link

This seems like a good place to start bringing in @viorelaioia to help with Q&A...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants