-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create repositories referenced on a revision #2530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great already 👍
da1b458
to
c62044d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also create the repository automatically from load_issues
command when it's not in DB ?
Same rules as from the API
- must belong to the list of known repos
- slug from parsed path (stripping leading
/
)
1834015
to
e80f654
Compare
Could we also remove repositories with no revisions attached in the cleanup script? This way we don't accrue noise in the repository table (e.g. if a repository is added on Phab and later removed or renamed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes are OK, Repositories are created without leading /
both from the API & load_issues.
Please implement the cleanup mentionned by @marco-c and we should be ready to merge
5eae12f
to
dc62f9c
Compare
backend/code_review_backend/issues/management/commands/cleanup_issues.py
Outdated
Show resolved
Hide resolved
...end/code_review_backend/issues/migrations/0015_remove_repository_phid_alter_repository_id.py
Show resolved
Hide resolved
backend/code_review_backend/issues/management/commands/load_issues.py
Outdated
Show resolved
Hide resolved
525beaf
to
aeef32e
Compare
aeef32e
to
4552c4d
Compare
4552c4d
to
b78af8c
Compare
Closes #2521