Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep sentry-sdk to 1.22.2 for the moment #1804

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

abpostelnicu
Copy link
Collaborator

sentry-sdk 1.23 and after has some issues with our code. COMMON_RECORD_ATTRS is not exposed directly in interations.
The introduction of loguru to the sdk broke our integration.

@abpostelnicu
Copy link
Collaborator Author

Unfortunately we don't have tests for this.

@abpostelnicu abpostelnicu changed the title Master Keep sentry-sdk to 1.22.2 for the moment Jul 4, 2023
@abpostelnicu abpostelnicu force-pushed the master branch 2 times, most recently from ed84627 to 0cd3a7b Compare July 4, 2023 11:53
@abpostelnicu abpostelnicu marked this pull request as ready for review July 5, 2023 03:58
@abpostelnicu abpostelnicu requested a review from marco-c July 5, 2023 03:58
marco-c
marco-c previously approved these changes Jul 31, 2023
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I totally missed this

@abpostelnicu abpostelnicu merged commit 611b070 into mozilla:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants