Resolve fully-qualified associated types #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
force-pushed
the
parse-assoc-types
branch
from
c15a902
to
cda3c70
Compare
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
orangeng
changed the title
orangeng
changed the title
orangeng
force-pushed
the
parse-assoc-types
branch
from
cda3c70
to
712ca52
Compare
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
orangeng
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
2cd1735
to
a76a4e8
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
a76a4e8
to
beb281c
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
beb281c
to
3ff88a9
Compare
mversic
force-pushed
the
parse-assoc-types
branch
4 times, most recently
from
fa24f93
to
2895b55
Compare
|
@emilio is there something blocking the merge of this feature? |
mversic
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
c7f64b2
to
5258104
Compare
|
@emilio do you think we can get this PR merged soon? |
mversic
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
4cd9216
to
862232e
Compare
|
We're currently using this in prod. Would love to get this merged in! Without this PR out entire cbindgen flow wouldn't work. Thanks @orangeng for your awesome contribution! |
mversic
force-pushed
the
parse-assoc-types
branch
from
862232e
to
60fabe5
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
60fabe5
to
5edf653
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
5edf653
to
bbf7444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the parsing stage, the functionality of the syn::Impl parsing is extended to keep track of associated type implementations in trait Impls.
This info is kept in a hash-map, where the key is a combination of (self type, trait name, associated type name) and the value is the concrete type itself.
In the library/transformation stage, this populated hashmap is then referenced to resolve associated types found.
Closes #106