-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin serde #271
Unpin serde #271
Conversation
This bumps the minimal supported `rustc` version to 1.32.
I'm not sure we can do this yet because of Firefox's rust update policy. Firefox currently requires only 1.29, and cbindgen is used during the build. But yes, I definitely want to do this ASAP. |
Yeah, from the stable+2weeks policy, we should be able to require 1.32 on Jan 31, which is a few days into the Firefox 67 Nightly cycle. |
What's the status here? Having this PR released would really useful as it would finally allow publishing crates depending cbindgen and recent serde versions. |
I'll take a look at doing this now that we can require 1.32. Just got back from vacation. |
So it looks like Firefox doesn't yet require 1.32. I've posted a comment requesting that they increment the minimum required version. |
Looks like the patch to require 1.32 has been pushed. Once it's merged we should be able to do a release with this. |
Generate simpleservo.h Fix #22834 Waiting on mozilla/cbindgen#271 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22844) <!-- Reviewable:end -->
This bumps the minimum required
rustc
version to 1.32.Updating
serde_derive
breaks the builds forrustc < 1.32
. See #203 for details.After updating to today's stable release, this is no longer an issue. 🎉
Closes #203.