Replaced Items’ String-based names with proper Paths #233
Conversation
|
@regexident Could you give this a glance? It's your work rebased and updated. It looks good to me, but I'd like another pair of eyes to make sure I didn't mess up anything your were doing. |
|
There is one functional change here that I can see. We should now mangle the names of the tag enum for C headers when we generate monomorphs. As far as I can tell, this was a bug that we weren't doing this. |
Looks good to me. Thanks for the rebase!
Yes, I stumbled upon it as well. |
|
I think the GitHub outage bricked the CI queue. You may have to manually re-trigger Travis-CI. |
eqrion
force-pushed
the
fix/path-all-the-things
branch
from
8ecaa05 to
ffff824
Compare
|
Looks like the test failed because of rustfmt. Here's another try. |
|
Fixed and merged. Thanks @regexident! |
|
|
|
This change should probably have been a breaking change. It made the I'll update cbindgen on mozilla-central, so no action needed I guess, but wanted to point that out. |
|
Hmm, actually I think it may be better if we keep it the way it was... I'll see how hard it is to fix. |
|
Actually I think the new behavior is saner, let's keep that, add a test, and I'll take care of all versions building with old cbindgen versions. |
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301 --HG-- extra : moz-landing-system : lando
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301 UltraBlame original commit: 5b0e4820c7fbd5c21451c9e72b103b5555664e3a
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301 UltraBlame original commit: 5b0e4820c7fbd5c21451c9e72b103b5555664e3a
mozilla/cbindgen#233 changed the way one of the options we use work. I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds. Differential Revision: https://phabricator.services.mozilla.com/D10301 UltraBlame original commit: 5b0e4820c7fbd5c21451c9e72b103b5555664e3a
This is a rebased and updated version of #201.