Don't prompt to renew expiring wildcard audits for inactive crates #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes some test outputs, as dates are now written as dates relative to January 1, 2023 (which is "today" for the purposes of tests). Using dates defined relative to "today" makes how it will interact with other checks in cargo-vet more clear.
afranchuk
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
This is great!
One minor nitpick is that I think the tests could use the WILDCARD_AUDIT_INACTIVE_CRATE_DURATION so that the tests are done relative to that value (if it changes, the tests won't start failing). Likewise some of the tests have comments which explicitly mention "16 weeks", but to avoid them getting out of sync it could just say "the expiry duration" or something like that.
This silences the wildcard audit renewal warning for crates which have not been updated in at least 4 months, and haven't been updated since the wildcard audit has expired. Fixes mozilla#647
mystor
force-pushed
the
wildcard_warn_less
branch
from
ce53e93 to
0686d83
Compare
|
I'll mention that time in comments, but I think I prefer having the test independently verify the time spans rather than deriving the spans directly from the value used in main.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences the wildcard audit renewal warning for crates which have not been updated in at least 4 months, and haven't been updated since the wildcard audit has expired.
Fixes #647