survey_sec_bugs: Do not set needinfo towards unassigned bugs #1241
Conversation
| @@ -14,6 +14,9 @@ def description(self): | |||
| return "Submit survey to assignee of a security bug" | |||
|
|
|||
| def get_bz_params(self, date): | |||
| assignee_skiplist = self.get_config("assignee_skiplist", default=[]) | |||
There was a problem hiding this comment.
You need to define a skiplist (it'd be assignee_skiplist) in configs/tools.json:
https://github.com/mozilla/relman-auto-nag/blob/28392fb0b835d9806b764c131b54998aba56d861/auto_nag/scripts/configs/tools.json#L633
But here I guess you want to use:
https://github.com/mozilla/relman-auto-nag/blob/master/auto_nag/utils.py#L101
with negation = True, in passing the params you already created.
This way your params will contain your stuff and something like (not ( assigned_to=="[email protected]" OR assigned_to="..." ... ))
Normally the function get_empty_assignees helps to filter out all the kind of "empty" assignees.
Is the mentioned bug in the email I sent having an assignee now ? |
|
@mozfreddyb is this something you still want to do? |
|
Yes, but I'm also very short on time. I think it's worth doing but not urgent. Is it OK for you to leave this in the queue? Also, I'd greatly appreciate if you assign this to me then, it'll show up in my list :-) |
I was unable to test this and might need some help either with my setup or from someone who can give this a quick smoketest directly. Pinging @calixteman