Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #1675 - Console User Interface (work by @raygervais) #752

Merged
merged 47 commits into from
May 9, 2017
Merged

Fix: #1675 - Console User Interface (work by @raygervais) #752

merged 47 commits into from
May 9, 2017

Conversation

humphd
Copy link

@humphd humphd commented May 9, 2017

This builds on #672, and replaces it.

raygervais added 30 commits March 31, 2017 12:33
@raygervais
Finalized PR style requests and removed redudant comments.
80303a9
@raygervais
Ported Console Interface from Referenced Implementation
191a916
@raygervais
Console UI now displays on load of web page
6e6f0c1
@raygervais
Fixed formatting
41c6b5e
@raygervais
Made ConsoleInterfaceManager.js see consoleTheme stylesheet
30c4f8e
@raygervais
added MIT License to ConsoleInterfaceManager.js
620b43a
@raygervais
Changed Console.* elements to from
4e5cecf
@raygervais
Changed console elements from input to div
922f331
@raygervais
Fixed Travis Build Errors, Added Error to enabled default filtering
8bb701c
@raygervais
Console is fed data only from ConsoleManager, which is the preview-wi…
4a7bfb9 
…ndow's console messages only.
@raygervais
Console now displays whenever user code triggers a console function
b8ec031
@raygervais
Added basic error-handling to ConsoleManagerRemote.js
e9f8b80
@raygervais
BlobURL handling added to error handler
2c72dd6
@raygervais
Appended Toggle Button to Editor Window
647892a
@raygervais
WIP: Blob Handling
4044099
@raygervais
Blob Handling Implemented using Regex
b6b1abd
@raygervais
Added ConsoleClosedByUser Variable, which won't display the console i…
7f85cfa 
…f the user intentionally closes it
@raygervais
Cleanup of filtering related functions, fixed styling of buttons
e6fdc1f
@raygervais
Updated Error Handling Model
88ee665
@raygervais
Fixed Formatting, moved Regex functions to ConsoleManager.js
028e6ab
@raygervais
Formatting of Object key-value pairs, revised handling of Blobs
e229bc6
@raygervais
Added Path plugin to blob handling
1d6aa8d
@raygervais
Updated Console to use light theme colors when editor is light theme
1558fd6
@raygervais
Removed Console buttons, updated styling for scrolling & text-select
ca3cc80
@raygervais
Localization Code Attempt, Recursive Error. :D
afc559f
@raygervais
Localization Second Attempt!
cb1c718
@raygervais
Merge branch 'master' into issue-1675
167becb
@raygervais
Spacing Issue Corrections
67bde93
@raygervais
Code Optimizations
f1f8f72
@raygervais
Localization Attempt Three, 'too much recursion' error
9a15baf
raygervais and others added 17 commits April 24, 2017 21:56
@raygervais
Merge branch 'issue-1675' of github.com:raygervais/brackets into issu…
fc2dd50 
…e-1675
@raygervais
Update ConsoleInterfaceManager.js
e189396
@raygervais
Checked out Master version of UI.JS
e763ff0
@raygervais
Merge branch 'issue-1675' of github.com:raygervais/brackets into issu…
dc336be 
…e-1675
@raygervais
Stylistic Change to Locales
b16a609
@raygervais
Fixed Recursion Issue, localization incomplete
30db391
@flukeout
Starting style updates
ee54d42
@flukeout
Console style & functionality updates
6817e31
@raygervais
Merge pull request #3 from flukeout/console-style-updates-3
ab05bc6 
Console updates & logic reworking
@raygervais
Merge branch 'master' into issue-1675
ab6f2a6
@humphd
Remove unnecessary icons
ba3e5b2
@humphd
Switch to less vs. css for stylesheet, fix some styling issues
41c41f0
@humphd
Undo whitespace changes in UI.js
3b157bc
@humphd
Always send args as a flat array
b283740
@humphd
Fix some edge cases when adding items to console UI.
6499478
@humphd
Remove broken stack pretty printing, we'll do this in a new bug
a5210c7
@humphd
Add extension build metadata for new console bits
ddee339
@humphd humphd mentioned this pull request May 9, 2017
Closed
@humphd humphd added the Launch label May 9, 2017
@humphd humphd merged commit ca4f169 into mozilla:master May 9, 2017
humphd added a commit that referenced this pull request May 9, 2017
@humphd
Revert "Fix: adobe#1675 - Console User Interface (work by @raygervais) (
896adeb 
#752)"

This reverts commit ca4f169.

There are changes in here not related to the PR.
@humphd
Copy link
Author

humphd commented May 9, 2017

I had to revert this. There are changes in here that aren't related to this PR. I'll have to hand edit it. cc @raygervais

@raygervais
Copy link

Once you finish editing, I'll pull & test again. Noticed a few odd things on a machine but updating that one's repo now to see if a fluke.

@humphd humphd mentioned this pull request May 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Launch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humphd @raygervais @flukeout