Drop 1st class support for IE9 (Fixes #7559) #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
force-pushed
the
ie9
branch
5 times, most recently
from
6aa7e88 to
6ed9d20
Compare
|
This is already looking great :) |
|
Ok, I think this is ready for code review! :) |
alexgibson
added
P2
Errolyn
approved these changes
Sep 11, 2019
|
we are going to have one more person look over this to make sure I didn't miss anything. |
|
It would be really great to try and get this merged soon if someone has time to take a second look |
craigcook
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
☘️ LGTM! Just noting that the fights-for-you page is being removed in #7738 so whichever of these merges first will create conflicts with the other. You've been reviewing that other PR already so here's an r+ from me and I'll leave it up to you to decide how to juggle the merges and rebases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue / Bugzilla link
#7559
Testing
Demo: https://www-demo1.allizom.org/en-US/firefox/
/firefox/new/page continues to get 1st class CSS./firefox/download/thanks/page continues to get 1st class CSS./firefoxpage gets 1st class CSS for the top hero section of the page only.Successful test run: https://ci.vpn1.moz.works/blue/organizations/jenkins/bedrock_multibranch_pipeline/detail/run-integration-tests/362/pipeline