Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser Support Page added #7554

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Browser Support Page added #7554

merged 1 commit into from
Aug 13, 2019

Conversation

hoosteeno
Copy link
Contributor

Fixes #7389

alexgibson
alexgibson requested changes Aug 12, 2019
View reviewed changes
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for taking the time to add this 💯

I think the file extension needs to be .rst, and this file also needs to be added to the table of contents in docs/index.rst.

If you run make docs locally then you can test out the build process.

docs/browser-support Outdated Show resolved Hide resolved
docs/browser-support Outdated Show resolved Hide resolved
alexgibson
alexgibson approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @hoosteeno 💯

@alexgibson alexgibson merged commit 5d9a5b3 into master Aug 13, 2019
@alexgibson alexgibson deleted the hoosteeno-patch-1 branch August 13, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgibson alexgibson alexgibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-evaluate browser support on bedrock.
2 participants
@hoosteeno @alexgibson