Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts WNP135 (#15852) #15903

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

maureenlholland
Copy link
Collaborator

@maureenlholland maureenlholland commented Jan 21, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.
⚠️ not sure if the WNP pages are moving to FXC yet, but it's relevant to FXC

One-line summary

UK/DE/FR should see Shortcuts-based WNP

Note: UK is geographically specified because the US and Canada will get a PDF-based WNP

Significant changes and points to review

Issue / Bugzilla link

#15852

Testing

Figma [Mozilla only]
Copy [Mozilla only]

UPDATE

@maureenlholland maureenlholland added the WIP 🚧 Pull request is still work in progress label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.29%. Comparing base (f13a56d) to head (c4c23da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15903   +/-   ##
=======================================
  Coverage   79.28%   79.29%           
=======================================
  Files         159      159           
  Lines        8343     8347    +4     
=======================================
+ Hits         6615     6619    +4     
  Misses       1728     1728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maureenlholland maureenlholland changed the title WIP: shortcuts wnp template Shortcuts WNP135 (#15852) Jan 21, 2025
It's not typical for our WNP templates to include special FTL files.
The only exceptions are an MDN-focused one and s2d (evergreen default).

Removing this all locale logic for now until it's confirmed we want to
go ahead with this many pontoon translations.
@maureenlholland maureenlholland force-pushed the wnp-135-shortcuts branch 2 times, most recently from 5d96e1d to 663de13 Compare January 21, 2025 21:09
@maureenlholland maureenlholland removed the WIP 🚧 Pull request is still work in progress label Jan 21, 2025
@maureenlholland maureenlholland marked this pull request as ready for review January 21, 2025 21:52
@maureenlholland maureenlholland requested review from a team as code owners January 21, 2025 21:52
@maureenlholland maureenlholland added P1 First level priority - Must have Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour Frontend HTML, CSS, JS... client side stuff WMO and FXC Code relevant to both the WMO and FXC projects labels Jan 21, 2025
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ nice work 🍡 (I'll leave it to you to merge when you're ready)

@alexgibson alexgibson removed Needs Review Awaiting code review WMO and FXC Code relevant to both the WMO and FXC projects labels Jan 22, 2025
@maureenlholland maureenlholland merged commit 1960712 into mozilla:main Jan 22, 2025
5 checks passed
@maureenlholland maureenlholland deleted the wnp-135-shortcuts branch January 22, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff P1 First level priority - Must have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants