-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcuts WNP135 (#15852) #15903
Shortcuts WNP135 (#15852) #15903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15903 +/- ##
=======================================
Coverage 79.28% 79.29%
=======================================
Files 159 159
Lines 8343 8347 +4
=======================================
+ Hits 6615 6619 +4
Misses 1728 1728 ☔ View full report in Codecov by Sentry. |
2d1ee96
to
fca7ad0
Compare
fca7ad0
to
148629c
Compare
It's not typical for our WNP templates to include special FTL files. The only exceptions are an MDN-focused one and s2d (evergreen default). Removing this all locale logic for now until it's confirmed we want to go ahead with this many pontoon translations.
5d96e1d
to
663de13
Compare
663de13
to
e7c0808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ nice work 🍡 (I'll leave it to you to merge when you're ready)
If this changeset needs to go into the FXC codebase, please add the
⚠️ not sure if the WNP pages are moving to FXC yet, but it's relevant to FXC
WMO and FXC
label.One-line summary
UK/DE/FR should see Shortcuts-based WNP
Note: UK is geographically specified because the US and Canada will get a PDF-based WNP
Significant changes and points to review
Issue / Bugzilla link
#15852
Testing
Figma [Mozilla only]
Copy [Mozilla only]
en
locale and GB country: http://localhost:8000/en-US/firefox/135.0/whatsnew/?geo=GBen
locale and GB country: http://localhost:8000/es-ES/firefox/135.0/whatsnew/?geo=GBen
locale not in GB country: http://localhost:8000/en-US/firefox/135.0/whatsnew/?geo=USfr
locale: http://localhost:8000/fr/firefox/135.0/whatsnew/de
locale: http://localhost:8000/de/firefox/135.0/whatsnew/UPDATE
en-GB
locale, regardless of country: http://localhost:8000/en-GB/firefox/135.0/whatsnew/