Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Breadcrumb links on firefox/feature pages which are misaligned #14253

Closed
wants to merge 2 commits into from

Conversation

Ayushsunny
Copy link
Contributor

One-line summary

Aligned the Protocol breadcrumbs component on firefox/feature pages with the rest of the page content and added additional padding for improved clickability.

Significant changes and points to review

Issue / Bugzilla link

#14081

Testing

  • Opened the specified URL in Firefox Nightly on macOS.
  • Verified that the breadcrumb links are now aligned with the navigation links.
  • Checked the padding of the breadcrumb links to ensure they are easier to click.
  • Tested the behavior on different screen sizes to ensure responsiveness.

Before
before

After
after1

@Ayushsunny
Copy link
Contributor Author

@alexgibson Review

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 67.96875% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 76.58%. Comparing base (4deaca3) to head (d431112).
Report is 1404 commits behind head on main.

Files Patch % Lines
...rock/base/management/commands/update_www_config.py 0.00% 38 Missing ⚠️
bedrock/firefox/redirects.py 14.28% 12 Missing ⚠️
bedrock/careers/views.py 65.38% 9 Missing ⚠️
bedrock/contentful/api.py 69.56% 7 Missing ⚠️
...ontentful/management/commands/update_contentful.py 89.36% 5 Missing ⚠️
bedrock/base/middleware.py 92.68% 3 Missing ⚠️
...tcards/management/commands/update_content_cards.py 0.00% 2 Missing ⚠️
...lfiles/management/commands/update_externalfiles.py 0.00% 2 Missing ⚠️
bedrock/base/templatetags/helpers.py 85.71% 1 Missing ⚠️
bedrock/base/views.py 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14253      +/-   ##
==========================================
- Coverage   76.72%   76.58%   -0.15%     
==========================================
  Files         147      145       -2     
  Lines        7344     7802     +458     
==========================================
+ Hits         5635     5975     +340     
- Misses       1709     1827     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@craigcook craigcook self-assigned this Mar 1, 2024
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may fix the issue, but I'm afraid the solution of loading an existing style sheet from an entirely unrelated page is not adequate. Please seek a better solution that doesn't introduce so much redundant CSS. Thank you

(the style sheet you have loaded also no longer exists in the main branch)

@alexgibson
Copy link
Member

Superseded by #14413

@alexgibson alexgibson closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants