Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile app store redirector (Issue #14172) #14208

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Feb 15, 2024

One-line summary

Adds a helper that detects Android/iOS and then redirects to the appropriate mobile app store URL (with optional campaign parameters). Default fallback is to Apple App Store.

Note: the redirect at firefox/browsers/mobile/app/ isn't used by anything yet, but my hope is to use this URL to embed inside QR Codes, as a replacement for Adjust links in #14172

Issue / Bugzilla link

#14172

Testing

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ff5010f) 76.93% compared to head (d60a99f) 76.72%.

Files Patch % Lines
bedrock/firefox/redirects.py 14.28% 12 Missing ⚠️
bedrock/redirects/util.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14208      +/-   ##
==========================================
- Coverage   76.93%   76.72%   -0.21%     
==========================================
  Files         145      145              
  Lines        7843     7868      +25     
==========================================
+ Hits         6034     6037       +3     
- Misses       1809     1831      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgibson alexgibson marked this pull request as ready for review February 15, 2024 13:01
@alexgibson alexgibson added Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Feb 15, 2024
@alexgibson
Copy link
Member Author

@stevejalim @robhudson if either of you can find some time to review this (since it's mostly python) it would be appreciated? (not urgent though) Thanks!

Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: r+


OLD: r+wc 👍

Works fine, but have a suggestion for simplifying the querystring checking

bedrock/firefox/redirects.py Show resolved Hide resolved
@stevejalim stevejalim merged commit 6da7ca2 into mozilla:main Feb 15, 2024
5 checks passed
@alexgibson alexgibson deleted the app-store-redirector branch February 15, 2024 15:14
@alexgibson alexgibson removed Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Apr 16, 2024
@alexgibson alexgibson self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants