Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced non-Mozilla product Fluent terms w/ regular string in /browsers/compare/ update #14206

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

reemhamz
Copy link
Contributor

One-line summary

In a previous PR where we removed mentions of IE and updated Fluent string IDs, I kept the Fluent terms of non-Mozilla products in the new versions of the Fluent string IDs. Flod flagged them in this PR. I managed to now replace the Fluent terms with strings.

Initial PR where these string IDs were created: #14167

i.e.
string-about-safari = Comparing { -brand-name-safari } --> string-about-safari = Comparing Safari

Issue / Bugzilla link

mozilla-l10n/www-l10n#375

Testing

@reemhamz
Copy link
Contributor Author

@flodolo let me know if this is good to go

Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's exactly what I was asking for 👍🏼

There is one typo, and one open question about Safari and Windows.

l10n/en/firefox/browsers/compare/index.ftl Outdated Show resolved Hide resolved
l10n/en/firefox/browsers/compare/index.ftl Outdated Show resolved Hide resolved
@reemhamz reemhamz added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Feb 14, 2024
@craigcook craigcook merged commit 64b5811 into mozilla:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants