Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS error in GA4 event tracking (Fixes #14177) #14178

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Feb 5, 2024

One-line summary

Fixes an error that is caused when trying to send an event and getEventFromUrl() returns a boolean instead of an object.

Issue / Bugzilla link

#14177

Testing

  1. Open http://localhost:8000/en-US/firefox/122.0/releasenotes/
  2. Open the web console and make sure you have "Persist logs" checked.
  3. Scroll to the bottom of the page where it says "Get the most recent version" and click "Download Firefox"
  4. Verify there is no longer a JS error on click.

@alexgibson alexgibson added P2 Second level priority - Should have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Feb 5, 2024
@craigcook craigcook self-assigned this Feb 5, 2024
Copy link
Contributor

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪤

@craigcook craigcook merged commit 9b06488 into mozilla:main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P2 Second level priority - Should have Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants