Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String fixes for Linux download buttons #14171

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

craigcook
Copy link
Contributor

One-line summary

Minor fixes to the Linux button strings, based on feedback in mozilla-l10n/www-l10n#372 (comment)

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R +

@stephaniehobson stephaniehobson merged commit a270670 into mozilla:main Feb 2, 2024
6 checks passed
@craigcook craigcook deleted the string-fixes branch February 2, 2024 01:37
@flodolo
Copy link
Contributor

flodolo commented Feb 2, 2024

@craigcook

These strings were already exposed to translation (you merged the PR a few hours ago), and we already have several translations. You need to use a new ID, since the string changes beyond the term.

@craigcook
Copy link
Contributor Author

#14174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants