Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adjust links (Fixes #11698) #14125

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 26, 2024

One-line summary

Removes Adjust links and replaces them with native app store links and default campaign parameters. Uses this spreadsheet for reference (Mozilla access only).

Significant changes and points to review

There are still adjust URLs wrapped up inside some QR Codes on certain pages, but that will have to be handled in a separate issue. But with this change there shouldn't be any more adjust links in HTML pages. Some additional searching / checking would be helpful to make sure I didn't miss any?

Issue / Bugzilla link

#11698

Testing

Check Links / buttons all still go to the right products

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (529ba2b) 77.11% compared to head (fa716db) 76.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14125      +/-   ##
==========================================
- Coverage   77.11%   76.92%   -0.19%     
==========================================
  Files         145      145              
  Lines        7897     7837      -60     
==========================================
- Hits         6090     6029      -61     
- Misses       1807     1808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgibson alexgibson force-pushed the remove-adjust branch 7 times, most recently from 3d0a875 to 3ab4fa6 Compare February 7, 2024 15:01
@alexgibson
Copy link
Member Author

@alexgibson alexgibson marked this pull request as ready for review February 7, 2024 16:41
@alexgibson alexgibson added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour P2 Second level priority - Should have labels Feb 7, 2024
@reemhamz reemhamz self-assigned this Feb 12, 2024
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and seamless change. r+! 🌟

@reemhamz reemhamz merged commit b2c56cb into mozilla:main Feb 13, 2024
5 checks passed
@alexgibson alexgibson deleted the remove-adjust branch June 17, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P2 Second level priority - Should have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants