Adding landing page for lapsed users #13680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-barrett
added
Needs Review
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #13680 +/- ##
==========================================
- Coverage 76.65% 76.60% -0.05%
==========================================
Files 147 145 -2
Lines 7878 7930 +52
==========================================
+ Hits 6039 6075 +36
- Misses 1839 1855 +16
☔ View full report in Codecov by Sentry. |
nathan-barrett
force-pushed
the
pip-landing
branch
from
08629f1 to
784b633
Compare
craigcook
suggested changes
Sep 15, 2023
There was a problem hiding this comment.
A few other thoughts/questions:
- Should this page live under /firefox?
- If we're localizing the page, the video is only in English so that's not great. There are captions in French and German which is something, but if this is being targeted to more languages we should consider a different video.
- We have https://www.mozilla.org/firefox/features/picture-in-picture/ that could serve the same purpose, and is already localized in a bunch of languages (and uses a wordless video). Unless they really want this separate page for other reasons, but I also suspect the folks requesting this may not know that feature page even exists. If there's a compelling reason to make a new page we can obviously do that, but we should mention that we do already have one.
nathan-barrett
force-pushed
the
pip-landing
branch
from
eab9cbd to
4a28c09
Compare
craigcook
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Marketing requested a landing page that is essentially a copy of the WNP 113 for /en audiences. Lapsed windows users will be navigated to https://mozilla.org/try-picture-in-picture
Issue / Bugzilla link
No github issue but issue created in asana by @enavajas: https://app.asana.com/0/1204604936721242/1205104879786005/f
Testing
http://localhost:8000/try-picture-in-picture