Upgrading UniFFI to 0.25.2
#5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
requested review from
a team and
linabutler
and removed request for
a team
mhammond
approved these changes
Nov 20, 2023
Yeah, it probably is going to me. Let me double-check that it still is an issue. If so, I guess we need to fix mozilla/uniffi-rs#1736 and maybe release 0.25.4. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
=======================================
Coverage 27.43% 27.43%
=======================================
Files 379 379
Lines 48204 48204
=======================================
Hits 13224 13224
Misses 34980 34980 ☔ View full report in Codecov by Sentry. |
bendk
force-pushed
the
uniffi-0.25.2
branch
2 times, most recently
from
0b170ee to
e4baa50
Compare
Mostly mechanical, the one extra step was to add the `serde::derive` feature to `remote_settings`. I guess it's not pulling that feature in from `uniffi` anymore. oneshot is a new dependency for UniFFI. It specifies its license in Cargo.toml but doesn't include the file, so I linked to the official Apache 2.0 license text.
|
Updated this to also include There's a m-c patch that takes this. I'll try to trigger a try run there: https://phabricator.services.mozilla.com/D195155 Should we merge once everything is green there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly mechanical, the one extra step was to add the
serde::derivefeature toremote_settings. I guess it's not pulling that feature in fromuniffianymore.I think we should wait to merge until Glean has also upgraded to
0.25.2.Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.