Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon validation fails completely on large files #4055

Closed
Akkuma opened this issue Feb 17, 2017 · 3 comments
Closed

Addon validation fails completely on large files #4055

Akkuma opened this issue Feb 17, 2017 · 3 comments
Labels
needs:info repository:addons-server Issue relating to addons-server

Comments

@Akkuma
Copy link

Akkuma commented Feb 17, 2017

Describe the problem and steps to reproduce it:

File is too large to parse, upload an extension with a file larger than 4MB

What happened?

Receive the error "File is too large to parse", so cannot sign an unlisted addon that is a develop build that isn't minified.

What did you expect to happen?

Get a signed extension

Anything else we should know?

https://addons.mozilla.org/en-US/developers/upload/d0a95d7b4efd47008b2b7e7fc5bec167

@jvillalobos
Copy link

Can you please share the file you're trying to upload? Is this currently blocking you from submitting your add-on?

@diox diox added the triaged label Mar 21, 2017
@muffinresearch
Copy link
Contributor

Closing this due to lack of information. Please re-open this if you're still experiencing the problem.

@gorhill
Copy link

gorhill commented Aug 11, 2023

I received the same error when trying to have my extension signed:

Screenshot from 2023-08-11 18-32-36

Validation URL is: https://addons.mozilla.org/en-US/developers/upload/c65513ae305a4cdbaf4600dad60af212

Two files are larger than 4 MB in the extension:

Screenshot from 2023-08-11 18-34-33

These are ruleset files to be used by the declarativeNetRequest API, the only workaround I can see is:

  • Do not prettify the generated JSON, which results in default.json shrinking to 3.6 MB
  • Do not ship stevenblack-hosts.json DNR ruleset, it's still at 5.3 MB without pretty JSON

The extension package: https://github.com/gorhill/uBlock/releases/download/uBOLite_1.0.23.8118/uBOLite_1.0.23.8118.firefox.mv3.xpi uBOLite_1.0.23.8118.firefox.mv3.zip, and it's the first release of uBO Lite for Firefox which I expect to be as functional as the Chromium version.


Update: After some more thoughts, I did find a workaround to reduce the size of the DNR ruelset files. I could bring down the size as follow:

  • default.json shrinked to 3.1 MB (from 4.7 MB originally)
  • stevenblack-hosts.json shrinked to 2.5 MB (from 6.4 MB originally)

So it's no longer an obstacle at the moment to publish my extension on AMO, but eventually this still should be addressed as there is no documented limit how how large a DNR ruleset file can be.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

6 participants