chore(package): update webpack to version 4.4.1 #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #1927, which fails on travis because webpack 4 also requires webpack-cli to be explicitly installed as a separate dev dependency.
This pull request also set the new webpack
mode
config property to'none'
, which seems to restore most of the default behaviors of webpack3, otherwise the build step raise a number ofModuleConcatenation bailout: Module is not an ECMAScript module
warning messages (and an additional warning message which complains about the missingmode
config property and warns that webpack 4 will defaults to the newmode: 'production'
behavior when the explicitmode
is missing).I also briefly tested locally that the new webpack4 bundle is able to run successfully from the addons-linter bin script (and that the
npm run extract-locales
script is able to extract the i18n strings as expected, given that it is also based on a webpack config and it could have been affected by a webpack upgrade).