Respect prefers-reduced-motion: reduce #9352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @muffinresearch as we discussed it a couple weeks ago. |
|
Test failures are unrelated (see: mozilla/addons#13726) |
bobsilverberg
approved these changes
Apr 13, 2020
|
It's only CSS so I am going to merge this PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#12593
This patch adds some
prefers-reduced-motionmedia queries to disable animations for the following components:AMInstallButton: see "Cylon" animation for installing add-ons also inflicts migraines addons#12593LoadingText: I am not sure we have an issue for that yet but I think if "Cylon" animation for installing add-ons also inflicts migraines addons#12593 is a problem then the animation for this component is also a problemScreenshots/Gifs
Before
regular install button:
"puffy" install button:
Loading indicator:
After
regular install button:
"puffy" install button:
Loading indicator: