-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable hot-word boosting #3297
Merged
Merged
enable hot-word boosting #3297
Changes from 44 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
26155ac
enable hot-word boosting
JRMeyer 3745a51
more consistent ordering of CLI arguments
JRMeyer 9a3be21
progress on review
JRMeyer 2b44f74
use map instead of set for hot-words, move string logic to client.cc
JRMeyer 42f1f3a
typo bug
JRMeyer 103ee93
pointer things?
JRMeyer 81157f5
use map for hotwords, better string splitting
JRMeyer ba80943
add the boost, not multiply
JRMeyer ff74bd5
cleaning up
JRMeyer b997bab
cleaning whitespace
JRMeyer 6fbad16
remove <set> inclusion
JRMeyer 96cd43d
change typo set-->map
JRMeyer d3a5378
rename boost_coefficient to boost
JRMeyer cdf44aa
add hot_words to python bindings
JRMeyer d8a779d
missing hot_words
JRMeyer b047db2
include map in swigwrapper.i
JRMeyer 9e8ff99
add Map template to swigwrapper.i
JRMeyer 0fc3521
emacs intermediate file
JRMeyer c64c68b
map things
JRMeyer c805ab7
map-->unordered_map
JRMeyer 8c611bc
typu
JRMeyer 97b0416
typu
JRMeyer 82a582d
use dict() not None
JRMeyer 6155e43
error out if hot_words without scorer
JRMeyer 6df4297
two new functions: remove hot-word and clear all hot-words
JRMeyer 22af3c6
starting to work on better error messages
JRMeyer c90b054
better error handling + .Net ERR codes
JRMeyer b69a99c
allow for negative boosts:)
JRMeyer 753b62f
adding TC test for hot-words
JRMeyer a7a6dcc
add hot-words to python client, make TC test hot-words everywhere
JRMeyer 9c437c3
only run TC tests for C++ and Python
JRMeyer 63ccc4a
fully expose API in python bindings
JRMeyer 44bf59d
expose API in Java (thanks spectie!)
JRMeyer 4866341
expose API in dotnet (thanks spectie!)
JRMeyer 3d0b67d
expose API in javascript (thanks spectie!)
JRMeyer 6636a65
java lol
JRMeyer ecb3d27
typo in javascript
JRMeyer f742e05
commenting
JRMeyer 37a27f6
java error codes from swig
JRMeyer 90f1611
java docs from SWIG
JRMeyer 102445c
java and dotnet issues
JRMeyer fe7275e
add hotword test to android tests
JRMeyer 5432f56
dotnet fixes from carlos
JRMeyer 4945380
add DS_BINARY_PREFIX to tc-asserts.sh for hotwords command
JRMeyer ae1d39f
make sure lm is on android for hotword test
JRMeyer 90c6a87
path to android model + nit
JRMeyer 019a514
path
JRMeyer a382783
path
JRMeyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you measured perf impact with scorers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perf as in WER? or perf as in latency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not measured the latency effects yet, no.
Are there any TC jobs that do this, or should I profile locally? What do you recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, you'd have to do it locally. Using
perf
should be quite easy.