Live augmentation #2897
Merged
Live augmentation #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmankamp
force-pushed
the
live_augmentation
branch
from
c60fec6 to
3e333b3
Compare
tilmankamp
force-pushed
the
live_augmentation
branch
2 times, most recently
from
5e63baf to
0a331f0
Compare
tilmankamp
force-pushed
the
live_augmentation
branch
from
ad74c41 to
93c78b0
Compare
JRMeyer
reviewed
May 8, 2020
tilmankamp
force-pushed
the
live_augmentation
branch
2 times, most recently
from
f3907d7 to
cf84a32
Compare
…o PCM conversion support
tilmankamp
force-pushed
the
live_augmentation
branch
from
b193da8 to
c5ceee2
Compare
reuben
suggested changes
May 13, 2020
Co-authored-by: Reuben Morais <[email protected]>
tilmankamp
force-pushed
the
live_augmentation
branch
from
b265cb7 to
6737181
Compare
tilmankamp
force-pushed
the
live_augmentation
branch
from
6737181 to
f48b92c
Compare
tilmankamp
force-pushed
the
live_augmentation
branch
from
f48b92c to
f71f4d4
Compare
tilmankamp
force-pushed
the
live_augmentation
branch
from
f71f4d4 to
ac9a17d
Compare
reuben
approved these changes
May 18, 2020
| if len(value) == 2: | ||
| return ValueRange(target_type(value[0]), target_type(value[1]), 0) | ||
| if len(value) == 3: | ||
| return ValueRange(target_type(value[0]), target_type(value[1]), target_type(value[2])) |
There was a problem hiding this comment.
Nice catch on the repeated value[1]
Comment on lines
+31
to
+36
| """ | ||
| As the central distribution point for overlay samples this function is supposed to run in one process only. | ||
| This ensures that samples are not used twice if not required. | ||
| It loads the (raw and still compressed) data and provides it to the actual augmentation workers. | ||
| These are then doing decompression, potential conversion and overlaying in parallel. | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.