This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Implements Pagination (fixes #25) #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
force-pushed
the
25_pagination
branch
4 times, most recently
from
b254d8f to
d65c2cd
Compare
|
r? @leplatrem |
| 'description': "_limit should be an integer" | ||
| } | ||
| self.request.errors.add(**error_details) | ||
| raise errors.json_error(self.request.errors) |
There was a problem hiding this comment.
We now have a self.raise_invalid :)
| } | ||
| self.db.create(self.resource, 'bob', record) | ||
| self.resource.request.GET = {} | ||
| self.last_response.headers = {} |
There was a problem hiding this comment.
I don't think this should be necessary
|
Nice ! I suggest we add a few more tests that cover these parts of the code:
|
Natim
force-pushed
the
25_pagination
branch
4 times, most recently
from
9830a0c to
31e2a22
Compare
| limit = int(limit) | ||
| except ValueError: | ||
| error_details = { | ||
| 'name': None, |
There was a problem hiding this comment.
name None is default and could be dropped here (maybe your prefer explicit)
|
like @ametaireau would say : oh yeah :) 👍 |
added 10 commits
February 6, 2015 19:26
- When using pagination, deactivate multi-field sorting. - When not using pagination, all records are returned at once with multi-fields sorting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.