Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs about heartbeat status on warnings (200, not 5XX) #99

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

leplatrem
Copy link
Contributor

All implementation follow this logic:

if check_results.level < checks.ERROR:
        status_code = 200        
else:
        status_code = 500

@leplatrem leplatrem changed the title Fix docs heartbeat warnings Fix docs about heartbeat status on warnings (200, not 5XX) Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (2ba0254) to head (f670e83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          22       22           
  Lines         692      692           
  Branches       92       92           
=======================================
  Hits          678      678           
  Misses          8        8           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leplatrem leplatrem merged commit c939637 into main Feb 26, 2024
5 checks passed
@leplatrem leplatrem deleted the fix-docs-heartbeat-warnings branch February 26, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants