-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for django 4.0 #62
Conversation
@kernicPanel Could you try to rebase your PR on latest master? |
@leplatrem I rebased this PR. |
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 19 19
Lines 594 594
Branches 93 93
=======================================
Hits 581 581
Misses 9 9
Partials 4 4
Continue to review full report at Codecov.
|
Thanks, apparently that wasn't enough to make the tests pass :( |
That's because you're trying to build Django 4.0 support on Python 3.6/3.7. Django 4.0 requires Python 3.8 or greater. In addition, there is also a failure for py38-lint: |
Thanks for pointing this out, @diox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking this on, @kernicPanel !
Thanks for your support @diox and @leplatrem , I'm glad to have contributed! |
Django 4.0 introduces changes on middlewares, and signals. https://docs.djangoproject.com/en/4.0/releases/4.0/