Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 5.0 #90

Closed
jaredlockhart opened this issue Jan 8, 2024 · 0 comments · Fixed by #91
Closed

Add support for Django 5.0 #90

jaredlockhart opened this issue Jan 8, 2024 · 0 comments · Fixed by #91

Comments

@jaredlockhart
Copy link
Contributor

Django 5.0 is out now so let's add support here for it. Testing locally after updating I see:

  File "/usr/local/lib/python3.11/site-packages/dockerflow/django/middleware.py", line 8, in <module>
    from . import views
  File "/usr/local/lib/python3.11/site-packages/dockerflow/django/views.py", line 10, in <module>
    from .signals import heartbeat_failed, heartbeat_passed
  File "/usr/local/lib/python3.11/site-packages/dockerflow/django/signals.py", line 38, in <module>
    heartbeat_passed = Signal(providing_args=["level"])
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Signal.__init__() got an unexpected keyword argument 'providing_args'
jaredlockhart added a commit to JaredLockhart-Mozilla/python-dockerflow that referenced this issue Jan 8, 2024
* Add Django 5.0 to the list of supported Django versions

fixes mozilla-services#90
leplatrem pushed a commit that referenced this issue Jan 9, 2024
* Add Django 5.0 to the list of supported Django versions

fixes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant