Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run_checks_async with Fastapi (or allow customization through configuration) #106

Closed
grahamalama opened this issue Mar 20, 2024 · 0 comments · Fixed by #114
Closed

Comments

@grahamalama
Copy link
Contributor

check_results = checks.run_checks(
checks.get_checks().items(),
)

This makes it so that you can't register async checks in a FastAPI app. We should

  • flip this to run_checks_async
    and/ or
  • allow users to customize which method they'd like to use to run checks
    and/or
  • introspect the registered checks and determine which function to use (if any of the registered checks are async, use run_checks_async
alexcottner added a commit that referenced this issue Apr 24, 2024
* Allowing for async checks in fastApi. Cleaning up old code. Fixes #106
* Added a few unit tests for fast_api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant