Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ber decoding with longer certs #53

Closed
wants to merge 3 commits into from

Conversation

manavk-p
Copy link

Allows for longer certs, such as some AWS certs, to be decoded properly. Taken from fullsailor#17

@manavk-p
Copy link
Author

manavk-p commented Jul 6, 2021

@ jvehent
This PR pulls in a change from a PR to fullsailor's repo. It allows for longer certs to be decoded without error.

@bernata
Copy link

bernata commented Aug 9, 2021

@g-k there are still some issues with this PR; the go.mod in particular and i think it would be useful to have a real cert that demonstrates the need for this fix. If I fix those two issues [or more if you have them], do you feel it would be ok to merge?

@g-k
Copy link

g-k commented Aug 9, 2021

@bernata Yes, I can take look, but I won't get to it until at least the end of the month.

Can you open a new PR with:

  • a fixed go.mod
  • a test with a real cert ideally from a well known service
  • fullsailor@d25ebd6 cherry picked from upstream
  • if applicable, tests from this branch 632789f (but not the merge back into master db74de8)

Thanks!

@g-k
Copy link

g-k commented Aug 26, 2021

Superseded by #61

@g-k g-k closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants