One transaction per request #510
Conversation
leplatrem
force-pushed
the
a-transaction-per-request
branch
3 times, most recently
from
e932fdd to
db66ad3
Compare
leplatrem
force-pushed
the
a-transaction-per-request
branch
5 times, most recently
from
480713b to
a8b8cec
Compare
|
|
||
| - A transaction now covers the whole request/response cycle (#510, Kinto/kinto#194). | ||
| If an error occurs during the request processing, every operation performed | ||
| is rolled back. **Note:** This is only enabled with *PostgreSQL* backends. |
There was a problem hiding this comment.
what happens when I have a postgres backend for the storage and redis for the cache ? can you confirm cache changes are also rolled back ?
leplatrem
force-pushed
the
a-transaction-per-request
branch
2 times, most recently
from
13668b9 to
cb3d55c
Compare
|
This is now ready to review/merge |
| """ | ||
| connection = None | ||
| trans = None | ||
| with_transaction = (not readonly and self.commit_manually) |
There was a problem hiding this comment.
you don't need parentheses
There was a problem hiding this comment.
I know, it's a custom we have for boolean exprs. Do you want me to get rid of it ?
There was a problem hiding this comment.
My reference is always the (recent) Python stdlib for style. It's not considered "pythonic" to have superfluous characters. The typical example is for tuple.
one = two, three, four # do this
one = (two, three, four) # not thisOne exception of avoiding \ to break a line.
e.g. do:
import (one, two,
three) # yes!!
import one, two, \
three # boooo!So I guess my question is: what's the benefit for our code base to do this differently ? If none, I am +1 to use Python stdlib conventions. (We should check of course that it's wlays done like that there :))
localtimestamp always returns the same timestamp within a transaction. clock_timestamp() is a lot more precise, and differs even within the same statement. SELECT clock_timestamp() = clock_timestamp(); > false
leplatrem
force-pushed
the
a-transaction-per-request
branch
from
cb3d55c to
534cdb4
Compare
|
r+ |
Perform one transaction per request (Kinto/kinto#194)
Relax content-type validation when no body is posted (fixes #507)
Two-phase commit accross backends ?Session is shared accross backends if URL is the same