Merge pull request #639 from mozilla-services/track-statsd-by-policy

StatsD execution timer by sub-policy

cliquet/initialization.py

@@ -33,7 +33,8 @@
 from pyramid.security import NO_PERMISSION_REQUIRED
 from pyramid.interfaces import IAuthenticationPolicy
 from pyramid.settings import asbool, aslist
-from pyramid_multiauth import MultiAuthPolicySelected
+from pyramid_multiauth import (MultiAuthenticationPolicy,
+                               MultiAuthPolicySelected)
 
 
 def setup_request_bound_data(config):
@@ -280,7 +281,13 @@ def setup_statsd(config):
         # Commit so that configured policy can be queried.
         config.commit()
         policy = config.registry.queryUtility(IAuthenticationPolicy)
-        client.watch_execution_time(policy, prefix='authentication')
+        if isinstance(policy, MultiAuthenticationPolicy):
+            for name, subpolicy in policy.get_policies():
+                client.watch_execution_time(subpolicy,
+                                            prefix='authentication',
+                                            classname=name)
+        else:
+            client.watch_execution_time(policy, prefix='authentication')
 
         def on_new_response(event):
             request = event.request

cliquet/statsd.py

@@ -15,8 +15,8 @@ class Client(object):
     def __init__(self, host, port, prefix):
         self._client = statsd_module.StatsClient(host, port, prefix=prefix)
 
-    def watch_execution_time(self, obj, prefix=''):
-        classname = utils.classname(obj)
+    def watch_execution_time(self, obj, prefix='', classname=None):
+        classname = classname or utils.classname(obj)
         members = dir(obj)
         for name in members:
             value = getattr(obj, name)

cliquet/tests/test_statsd.py

@@ -97,3 +97,11 @@ def test_statds_tracks_listeners_execution_duration(self):
         with mock.patch.object(statsd_client, 'timing') as mocked:
             self.app.get('/', headers=self.headers)
             self.assertTrue(mocked.called)
+
+    def test_statds_tracks_authentication_policies(self):
+        statsd_client = self.app.app.registry.statsd._client
+        with mock.patch.object(statsd_client, 'timing') as mocked:
+            self.app.get('/', headers=self.headers)
+            timers = set(c[0][0] for c in mocked.call_args_list)
+            self.assertIn('authentication.basicauth.unauthenticated_userid',
+                          timers)

setup.py

@@ -21,7 +21,7 @@
     'colander',
     'cornice >= 1.1',  # Fix cache CORS
     'python-dateutil',
-    'pyramid_multiauth >= 0.6',  # Policy name in event.
+    'pyramid_multiauth >= 0.7',  # Contained policy names.
     'pyramid_tm',
     'redis',  # Default backend
     'requests',