Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install ci-admin in Decision tasks #227

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ahal
Copy link
Contributor

@ahal ahal commented Dec 17, 2024

This fixes an issue when running the integration-test optimization.

@ahal ahal self-assigned this Dec 17, 2024
@ahal ahal requested a review from a team as a code owner December 17, 2024 19:20
@ahal
Copy link
Contributor Author

ahal commented Dec 17, 2024

/taskcluster integration

@ahal ahal force-pushed the push-wrznlmyukpuv branch 5 times, most recently from 9f45c25 to a8181cd Compare December 17, 2024 19:50
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahal
Copy link
Contributor Author

ahal commented Dec 17, 2024

Oops, this should have been draft, think I'm getting close though.

@ahal ahal marked this pull request as draft December 17, 2024 20:03
@ahal ahal force-pushed the push-wrznlmyukpuv branch 5 times, most recently from a6760b7 to 718e88b Compare December 17, 2024 20:46
@ahal
Copy link
Contributor Author

ahal commented Dec 17, 2024

This is more annoying than I thought it would be... Installing a package to the system's --user-site doesn't seem to put binaries on the $PATH, so the tc-admin invocation still fails.

@ahal
Copy link
Contributor Author

ahal commented Dec 17, 2024

uv to the rescue!

@ahal ahal force-pushed the push-wrznlmyukpuv branch from 7fa3a71 to 9e35e50 Compare December 17, 2024 21:01
@ahal
Copy link
Contributor Author

ahal commented Dec 17, 2024

Note that the integration tests are being scheduled on this PR because the optimization keeps them if anything under /taskcluster is modified. We can tweak this in a follow-up if we want to get more granular.

@ahal ahal marked this pull request as ready for review December 17, 2024 21:03
@ahal ahal merged commit f10fada into mozilla-releng:main Dec 17, 2024
28 checks passed
@ahal ahal deleted the push-wrznlmyukpuv branch December 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants