Skip to content

Commit

Permalink
ci: don't hide tc-admin stderr (#233)
Browse files Browse the repository at this point in the history
tc-admin diff uses the same exit code (1) both for "there was an error"
and "I found differences", so its error output is basically the only way
we can differentiate currently.
  • Loading branch information
jcristau authored Dec 18, 2024
1 parent 2c65afd commit c3c0f94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion taskcluster/fxci_config_taskgraph/optimizations.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def _get_modified_worker_pools(self) -> set[str]:
]
env = os.environ.copy()
env["TASKCLUSTER_ROOT_URL"] = FIREFOXCI_ROOT_URL
proc = subprocess.run(cmd, capture_output=True, text=True, env=env)
proc = subprocess.run(cmd, stdout=subprocess.PIPE, text=True, env=env)
lines = [line for line in proc.stdout.splitlines() if line.startswith("!")]

worker_pools = set()
Expand Down

0 comments on commit c3c0f94

Please sign in to comment.