This repository has been archived by the owner on Dec 31, 2019. It is now read-only.
Allow Android-Components to ship 1.0.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 889
💛 - Coveralls |
MihaiTabara
approved these changes
Jun 21, 2019
| @@ -441,38 +441,40 @@ def test_beetmover_template_args_generation_release_is_jar(context): | |||
| 'artifact_id': 'fenix-megazord-forUnitTests', | |||
| 'is_jar': True, | |||
| 'template_key': 'maven_Fake', | |||
| 'version': '0.26.20990205110000', | |||
| 'version': '0.26.0', | |||
There was a problem hiding this comment.
Damn, this is my bad, sorry about injecting this bug long time ago.
| '', '1.0', 'browser-session', None, None, True, | ||
| 'components', '', '1.0.0', 'browser-session', None, '1.0.0', False, | ||
| ), ( | ||
| 'components', '', '1.0', 'browser-session', None, None, True, |
There was a problem hiding this comment.
Maybe in a follow-up: copy-paste this line with product == appservices to ensure this won't break whenever we'll switch to 1.0.0 there as well?
|
|
||
| if not raises: | ||
| assert generate_beetmover_template_args(context) == { | ||
| 'artifact_id': artifact_id, | ||
| 'template_key': 'maven_geckoview', | ||
| 'template_key': 'maven_{}'.format(product), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.