Remove assumptions about release blobs from rule evaluation #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
requested review from
gbrownmozilla and
gabrielBusta
as code owners
bhearsum
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
(I'm going to try using Conventional Comments for this review, FYI.)
I have a few non-blocking suggestions, but this looks good to me overall. Thank you for doing this!
jcristau
force-pushed
the
issue2985
branch
3 times, most recently
from
03fd4ab to
df51d7d
Compare
`evaluateRules` can't reliably call `blob.getApplicationVersion`, because that method is specific to certain types of blobs. Instead, we change the `blob.shouldServeUpdate` method to return a tristate instead of a boolean: `No` means no update should be served. `Maybe` means the update can be served but the pin version should be checked. `Yes` means the update should be served. In the `Maybe` case, `evaluateRules` can look for a release corresponding to the pin version and return that instead if found. Closes mozilla-releng#2985
jbuck
pushed a commit
to jbuck/balrog
that referenced
this pull request
Jun 15, 2024
…releng#3065) `evaluateRules` can't reliably call `blob.getApplicationVersion`, because that method is specific to certain types of blobs. Instead, we change the `blob.shouldServeUpdate` method to return a tristate instead of a boolean: `No` means no update should be served. `Maybe` means the update can be served but the pin version should be checked. `Yes` means the update should be served. In the `Maybe` case, `evaluateRules` can look for a release corresponding to the pin version and return that instead if found. Closes mozilla-releng#2985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2985