Stop showing scheduled deletions on unrelated channels

[michellemounde]

Fixes #2312:

1. Modify ruleMatchesChannel function to account for scheduled deletions
2. Rename tests for increased clarity on what is being tested
3. Create tests for scenarios that arose from rewording tests
4. Create tests for scheduled deletions matching

[bhearsum]

This appears to work, but I'm suspicious that something subtle is off here. I was expecting rule.scheduledChange.change_type === 'delete' to be treated specially - not to have all scheduled change types have this logic applied. For change_type === update or insert the channel should be matching if either the rule or rule.scheduledChange channel matches.

Could you try to make this a bit more clear? Feel free to drop the const on scChannelMatches and write this as if/else statements if it helps.

[michellemounde]

I wasn't sure whether to query for the change type initially or just make the function work for all scheduled changes. I appreciate the feedback and I'll work on making it clear.

[bhearsum]

This looks good, and my local testing can't find any cases that are displaying incorrectly. Thank you!