Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

log the payload when data collection is disabled, for QA purposes #532

Merged

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Apr 7, 2021

Checklist for reviewer:

  • The description should reference a bug or github issue, if relevant.
  • There must be a CHANGELOG.md entry for any non-test change.
  • Any change to the NPM commands must be carefully reviewed to make sure it won't break the Add-ons pipeline.
  • Any version increase must follow the release process.

@rhelmer rhelmer requested a review from Dexterp37 April 7, 2021 23:38
@rhelmer rhelmer self-assigned this Apr 7, 2021
@rhelmer
Copy link
Contributor Author

rhelmer commented Apr 7, 2021

@Dexterp37 I am finding it very difficult to QA studies that haven't been released yet, what do you think about doing this?

Happy to consider alternatives but I'd like to make it as easy as we can for folks doing this sort of testing. If we're concerned about potential leakage I could see dumping the encrypted payload instead but this would be pretty difficult for all but the most sophisticated test user :)

Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very reasonable! Please add a changelog entry :)

@rhelmer rhelmer force-pushed the log-payload-when-collection-disabled branch from 7f245c4 to 1ca2e14 Compare April 19, 2021 18:39
@rhelmer rhelmer merged commit 98b2a9e into mozilla-rally:master Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants